From 87ac5dcd0a2faa899aea238d3d24fc84407d1a62 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20Gl=C3=B6ckner?= Date: Tue, 29 Mar 2016 09:16:04 +0200 Subject: using const ref strings at input engine --- drumgizmo/input/inputdummy.cc | 2 +- drumgizmo/input/inputdummy.h | 2 +- drumgizmo/input/jackmidi.cc | 2 +- drumgizmo/input/jackmidi.h | 2 +- drumgizmo/input/midifile.cc | 2 +- drumgizmo/input/midifile.h | 2 +- plugin/drumgizmo_plugin.cc | 2 +- plugin/drumgizmo_plugin.h | 2 +- src/audioinputengine.h | 4 ++-- src/audioinputenginemidi.h | 2 +- 10 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drumgizmo/input/inputdummy.cc b/drumgizmo/input/inputdummy.cc index 74464ef..7d7b272 100644 --- a/drumgizmo/input/inputdummy.cc +++ b/drumgizmo/input/inputdummy.cc @@ -39,7 +39,7 @@ bool DummyInputEngine::init(Instruments& instruments) return true; } -void DummyInputEngine::setParm(std::string parm, std::string value) +void DummyInputEngine::setParm(const std::string& parm, const std::string& value) { } diff --git a/drumgizmo/input/inputdummy.h b/drumgizmo/input/inputdummy.h index 79f325a..f2353e5 100644 --- a/drumgizmo/input/inputdummy.h +++ b/drumgizmo/input/inputdummy.h @@ -36,7 +36,7 @@ public: // based on AudioInputEngine bool init(Instruments& instruments) override; - void setParm(std::string parm, std::string value) override; + void setParm(const std::string& parm, const std::string& value) override; bool start() override; void stop() override; void pre() override; diff --git a/drumgizmo/input/jackmidi.cc b/drumgizmo/input/jackmidi.cc index ff2f030..befb763 100644 --- a/drumgizmo/input/jackmidi.cc +++ b/drumgizmo/input/jackmidi.cc @@ -62,7 +62,7 @@ bool JackMidiInputEngine::init(Instruments& instruments) return true; } -void JackMidiInputEngine::setParm(std::string parm, std::string value) +void JackMidiInputEngine::setParm(const std::string& parm, const std::string& value) { if(parm == "midimap") { diff --git a/drumgizmo/input/jackmidi.h b/drumgizmo/input/jackmidi.h index fbf6ef1..5e9e48f 100644 --- a/drumgizmo/input/jackmidi.h +++ b/drumgizmo/input/jackmidi.h @@ -44,7 +44,7 @@ public: // based on AudioInputEngineMidi bool init(Instruments& instruments) override; - void setParm(std::string parm, std::string value) override; + void setParm(const std::string& parm, const std::string& value) override; bool start() override; void stop() override; void pre() override; diff --git a/drumgizmo/input/midifile.cc b/drumgizmo/input/midifile.cc index 5fc1a42..2149029 100644 --- a/drumgizmo/input/midifile.cc +++ b/drumgizmo/input/midifile.cc @@ -80,7 +80,7 @@ bool MidifileInputEngine::init(Instruments& instruments) return true; } -void MidifileInputEngine::setParm(std::string parm, std::string value) +void MidifileInputEngine::setParm(const std::string& parm, const std::string& value) { if(parm == "file") { diff --git a/drumgizmo/input/midifile.h b/drumgizmo/input/midifile.h index a5c79e4..ff2e3b6 100644 --- a/drumgizmo/input/midifile.h +++ b/drumgizmo/input/midifile.h @@ -43,7 +43,7 @@ public: // based on AudioInputEngineMidi bool init(Instruments& instruments) override; - void setParm(std::string parm, std::string value) override; + void setParm(const std::string& parm, const std::string& value) override; bool start() override; void stop() override; void pre() override; diff --git a/plugin/drumgizmo_plugin.cc b/plugin/drumgizmo_plugin.cc index 2a7e556..1a9ee34 100644 --- a/plugin/drumgizmo_plugin.cc +++ b/plugin/drumgizmo_plugin.cc @@ -188,7 +188,7 @@ bool DrumGizmoPlugin::Input::init(Instruments &instruments) return true; } -void DrumGizmoPlugin::Input::setParm(std::string parm, std::string value) +void DrumGizmoPlugin::Input::setParm(const std::string& parm, const std::string& value) { } diff --git a/plugin/drumgizmo_plugin.h b/plugin/drumgizmo_plugin.h index 4a4ec13..2d5789e 100644 --- a/plugin/drumgizmo_plugin.h +++ b/plugin/drumgizmo_plugin.h @@ -110,7 +110,7 @@ private: bool init(Instruments& instruments) override; - void setParm(std::string parm, std::string value) override; + void setParm(const std::string& parm, const std::string& value) override; bool start() override; void stop() override; diff --git a/src/audioinputengine.h b/src/audioinputengine.h index b218086..d7ac9c9 100644 --- a/src/audioinputengine.h +++ b/src/audioinputengine.h @@ -40,9 +40,9 @@ public: virtual bool isMidiEngine() { return false; } - virtual bool init(Instruments &instruments) = 0; + virtual bool init(Instruments& instruments) = 0; - virtual void setParm(std::string parm, std::string value) = 0; + virtual void setParm(const std::string& parm, const std::string& value) = 0; virtual bool start() = 0; virtual void stop() = 0; diff --git a/src/audioinputenginemidi.h b/src/audioinputenginemidi.h index 3f96afe..36fcbaa 100644 --- a/src/audioinputenginemidi.h +++ b/src/audioinputenginemidi.h @@ -45,7 +45,7 @@ public: virtual bool init(Instruments &instruments) = 0; - virtual void setParm(std::string parm, std::string value) = 0; + virtual void setParm(const std::string& parm, const std::string& value) = 0; virtual bool start() = 0; virtual void stop() = 0; -- cgit v1.2.3