From e8b37a3c47580a9e2fa7850b6defd2b5b97530d4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Christian=20Gl=C3=B6ckner?= <cgloeckner@freenet.de>
Date: Tue, 29 Mar 2016 09:37:45 +0200
Subject: using const ref strings at output engine

---
 drumgizmo/output/alsa.cc        | 2 +-
 drumgizmo/output/alsa.h         | 2 +-
 drumgizmo/output/jackaudio.cc   | 2 +-
 drumgizmo/output/jackaudio.h    | 2 +-
 drumgizmo/output/outputdummy.cc | 2 +-
 drumgizmo/output/outputdummy.h  | 2 +-
 drumgizmo/output/wavfile.cc     | 2 +-
 drumgizmo/output/wavfile.h      | 2 +-
 plugin/drumgizmo_plugin.cc      | 2 +-
 plugin/drumgizmo_plugin.h       | 2 +-
 src/audiooutputengine.h         | 2 +-
 11 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/drumgizmo/output/alsa.cc b/drumgizmo/output/alsa.cc
index 20a5366..3686656 100644
--- a/drumgizmo/output/alsa.cc
+++ b/drumgizmo/output/alsa.cc
@@ -120,7 +120,7 @@ bool AlsaOutputEngine::init(Channels channels)
 	return true;
 }
 
-void AlsaOutputEngine::setParm(std::string parm, std::string value)
+void AlsaOutputEngine::setParm(const std::string& parm, const std::string& value)
 {
 	if(parm == "dev")
 	{
diff --git a/drumgizmo/output/alsa.h b/drumgizmo/output/alsa.h
index f3fb457..4973f0b 100644
--- a/drumgizmo/output/alsa.h
+++ b/drumgizmo/output/alsa.h
@@ -43,7 +43,7 @@ public:
 
 	// based on AudioOutputEngine
 	bool init(Channels chan) override;
-	void setParm(std::string parm, std::string value) override;
+	void setParm(const std::string& parm, const std::string& value) override;
 	bool start() override;
 	void stop() override;
 	void pre(size_t nsamples) override;
diff --git a/drumgizmo/output/jackaudio.cc b/drumgizmo/output/jackaudio.cc
index 90ac63b..9f68edd 100644
--- a/drumgizmo/output/jackaudio.cc
+++ b/drumgizmo/output/jackaudio.cc
@@ -67,7 +67,7 @@ bool JackAudioOutputEngine::init(Channels data)
 	return true;
 }
 
-void JackAudioOutputEngine::setParm(std::string parm, std::string value)
+void JackAudioOutputEngine::setParm(const std::string& parm, const std::string& value)
 {
 }
 
diff --git a/drumgizmo/output/jackaudio.h b/drumgizmo/output/jackaudio.h
index e22d978..24348f6 100644
--- a/drumgizmo/output/jackaudio.h
+++ b/drumgizmo/output/jackaudio.h
@@ -41,7 +41,7 @@ public:
 
 	// based on AudioOutputEngine
 	bool init(Channels chan) override;
-	void setParm(std::string parm, std::string value) override;
+	void setParm(const std::string& parm, const std::string& value) override;
 	bool start() override;
 	void stop() override;
 	void pre(size_t nsamples) override;
diff --git a/drumgizmo/output/outputdummy.cc b/drumgizmo/output/outputdummy.cc
index 2edcc28..5899ead 100644
--- a/drumgizmo/output/outputdummy.cc
+++ b/drumgizmo/output/outputdummy.cc
@@ -39,7 +39,7 @@ bool DummyOutputEngine::init(Channels data)
 	return true;
 }
 
-void DummyOutputEngine::setParm(std::string parm, std::string value)
+void DummyOutputEngine::setParm(const std::string& parm, const std::string& value)
 {
 }
 
diff --git a/drumgizmo/output/outputdummy.h b/drumgizmo/output/outputdummy.h
index 023ba42..caa9e5f 100644
--- a/drumgizmo/output/outputdummy.h
+++ b/drumgizmo/output/outputdummy.h
@@ -36,7 +36,7 @@ public:
 
 	// based on AudioOutputEngine
 	bool init(Channels chan) override;
-	void setParm(std::string parm, std::string value) override;
+	void setParm(const std::string& parm, const std::string& value) override;
 	bool start() override;
 	void stop() override;
 	void pre(size_t nsamples) override;
diff --git a/drumgizmo/output/wavfile.cc b/drumgizmo/output/wavfile.cc
index b19f700..e81fb2d 100644
--- a/drumgizmo/output/wavfile.cc
+++ b/drumgizmo/output/wavfile.cc
@@ -69,7 +69,7 @@ bool WavfileOutputEngine::init(Channels data)
 	return true;
 }
 
-void WavfileOutputEngine::setParm(std::string parm, std::string value)
+void WavfileOutputEngine::setParm(const std::string& parm, const std::string& value)
 {
 	if(parm == "file")
 	{
diff --git a/drumgizmo/output/wavfile.h b/drumgizmo/output/wavfile.h
index 1dddfa1..331733b 100644
--- a/drumgizmo/output/wavfile.h
+++ b/drumgizmo/output/wavfile.h
@@ -41,7 +41,7 @@ public:
 
 	// based on AudioOutputEngine
 	bool init(Channels data) override;
-	void setParm(std::string parm, std::string value) override;
+	void setParm(const std::string& parm, const std::string& value) override;
 	bool start() override;
 	void stop() override;
 	void pre(size_t nsamples) override;
diff --git a/plugin/drumgizmo_plugin.cc b/plugin/drumgizmo_plugin.cc
index 1a9ee34..4e3252d 100644
--- a/plugin/drumgizmo_plugin.cc
+++ b/plugin/drumgizmo_plugin.cc
@@ -246,7 +246,7 @@ bool DrumGizmoPlugin::Output::init(Channels channels)
 	return true;
 }
 
-void DrumGizmoPlugin::Output::setParm(std::string parm, std::string value)
+void DrumGizmoPlugin::Output::setParm(const std::string& parm, const std::string& value)
 {
 }
 
diff --git a/plugin/drumgizmo_plugin.h b/plugin/drumgizmo_plugin.h
index 2d5789e..bd970f1 100644
--- a/plugin/drumgizmo_plugin.h
+++ b/plugin/drumgizmo_plugin.h
@@ -132,7 +132,7 @@ private:
 
 		bool init(Channels channels) override;
 
-		void setParm(std::string parm, std::string value) override;
+		void setParm(const std::string& parm, const std::string& value) override;
 
 		bool start() override;
 		void stop() override;
diff --git a/src/audiooutputengine.h b/src/audiooutputengine.h
index 0a9d65b..a99d273 100644
--- a/src/audiooutputengine.h
+++ b/src/audiooutputengine.h
@@ -39,7 +39,7 @@ public:
 
   virtual bool init(Channels channels) = 0;
 
-  virtual void setParm(std::string parm, std::string value) = 0;
+  virtual void setParm(const std::string& parm, const std::string& value) = 0;
 
   virtual bool start() = 0;
   virtual void stop() = 0;
-- 
cgit v1.2.3