From d3d333b252925fbc95dd39fe73c5ce12a0017228 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Nusser?= Date: Fri, 10 Apr 2020 17:27:43 +0200 Subject: Fix some of the issues raised in the review. --- src/configfile.h | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'src/configfile.h') diff --git a/src/configfile.h b/src/configfile.h index 0934f46..a2f8db5 100644 --- a/src/configfile.h +++ b/src/configfile.h @@ -33,8 +33,7 @@ class ConfigFile { public: - // TODO: west-const - ConfigFile(std::string const& filename); + ConfigFile(const std::string& filename); virtual ~ConfigFile(); virtual bool load(); @@ -49,6 +48,10 @@ protected: std::fstream current_file; // TODO: Does this have to be virtual? + // Response: This is actually the only member function that has to be virtual. + // I find it very ugly that we have any virtual functions in here, but it + // seems that they were made virtual such that we can test this class properly. + // What do you think? Test differently and make it all non-virtual? virtual bool open(std::ios_base::openmode mode); std::string readLine(); bool parseLine(const std::string& line); -- cgit v1.2.3