diff options
| author | Arseny Kapoulkine <arseny.kapoulkine@gmail.com> | 2016-11-17 21:37:27 -0800 |
|---|---|---|
| committer | Arseny Kapoulkine <arseny.kapoulkine@gmail.com> | 2016-11-17 21:37:27 -0800 |
| commit | 9366f25136bcd471ce867abd4f737e2cb4bfebb1 (patch) | |
| tree | 482dbb3a7a3c9d6da11b9b2809a93e162d8b0f97 | |
| parent | 2af2524db5cad4be3773d2b4cd49254c0f0b7758 (diff) | |
Rename set_value_convert to set_value_bool
It's too dangerous to overload here - easy to accidentally mix floating point
path with boolean one.
| -rw-r--r-- | src/pugixml.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/pugixml.cpp b/src/pugixml.cpp index caa35c2..72cab1f 100644 --- a/src/pugixml.cpp +++ b/src/pugixml.cpp @@ -4640,7 +4640,7 @@ PUGI__NS_BEGIN } template <typename String, typename Header> - PUGI__FN bool set_value_convert(String& dest, Header& header, uintptr_t header_mask, bool value) + PUGI__FN bool set_value_bool(String& dest, Header& header, uintptr_t header_mask, bool value) { return strcpy_insitu(dest, header, header_mask, value ? PUGIXML_TEXT("true") : PUGIXML_TEXT("false"), value ? 4 : 5); } @@ -5312,7 +5312,7 @@ namespace pugi { if (!_attr) return false; - return impl::set_value_convert(_attr->value, _attr->header, impl::xml_memory_page_value_allocated_mask, rhs); + return impl::set_value_bool(_attr->value, _attr->header, impl::xml_memory_page_value_allocated_mask, rhs); } #ifdef PUGIXML_HAS_LONG_LONG @@ -6467,7 +6467,7 @@ namespace pugi { xml_node_struct* dn = _data_new(); - return dn ? impl::set_value_convert(dn->value, dn->header, impl::xml_memory_page_value_allocated_mask, rhs) : false; + return dn ? impl::set_value_bool(dn->value, dn->header, impl::xml_memory_page_value_allocated_mask, rhs) : false; } #ifdef PUGIXML_HAS_LONG_LONG |