summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-01-30XPath: Throw std::bad_alloc if we got an out-of-memory errorArseny Kapoulkine
This allows us to gradually convert exception handling of out-of-memory during evaluation to a non-throwing approach without changing the observable behavior.
2017-01-30tests: Add more tests for branch coverageArseny Kapoulkine
gcov -b surfaced many lines with partial coverage, where branch is only ever taken or not taken, or one of the expressions in a complex conditional is always either true or false. This change adds a series of tests (mostly focusing on XPath) to reduce the number of partially covered lines.
2017-01-30tests: Add an error propagation test for XPathArseny Kapoulkine
This test is supposed to test error coverage in different expressions that are nested in other expressions to reduce the number of never-taken branches in tests (and make sure we aren't missing any).
2017-01-30XPath: Reword brace mismatch errors for clarityArseny Kapoulkine
2017-01-30XPath: Improve error message for expressions like .[1]Arseny Kapoulkine
W3C specification does not allow predicates after abbreviated steps. Currently this results in parsing terminating at the step, which leads to confusing error messages like "Invalid query" or "Unmatched braces".
2017-01-30XPath: Track allocation errors more explicitlyArseny Kapoulkine
Any time an allocation fails xpath_allocator can set an externally provided bool. The plan is to keep this bool up until evaluation ends, so that we can use it to discard the potentially malformed result.
2017-01-30Enable branch probabilities for gcovArseny Kapoulkine
2017-01-29XPath: Provide non-throwing and throwing allocations in xpath_allocatorArseny Kapoulkine
For both allocate and reallocate, provide both _nothrow and _throw functions; this change renames allocate() to allocate_throw() (same for reallocate) to make it easier to change the code to remove throwing variants.
2017-01-29tests: Add query out of memory testArseny Kapoulkine
2017-01-29XPath: Minor error handling refactoringArseny Kapoulkine
Handle node type error before creating expression node
2017-01-29Add NO_EXCEPTIONS build to TravisArseny Kapoulkine
2017-01-29XPath: Route out-of-memory errors through the exceptionless pathArseny Kapoulkine
We currently need to convert error based on the text to a different type of C++ exceptions when C++ exceptions are enabled.
2017-01-29XPath: Forward all node constructors through alloc_nodeArseny Kapoulkine
This allows us to handle OOM during node allocation without triggering undefined behavior that occurs when placement new gets a NULL pointer.
2017-01-29XPath: Do not use exceptions to propagate parsing errorsArseny Kapoulkine
Instead, return 0 and rely on parsing logic to propagate that all the way down, and convert result to exception to maintain existing interface.
2017-01-29XPath: Assume that every function can fail and return 0Arseny Kapoulkine
Propagate the failure to the caller manually. This is a first step to parser structure that does not depend on exceptions or longjmp for error handling (and thus matches the XML parser). To preserve semantics we'll have to convert error code to exception later.
2017-01-29XPath: Minor parsing refactoringArseny Kapoulkine
Simplify function argument parsing by folding arg 0 parsing into the main loop, reuse expression parsing logic for unary expression
2017-01-29XPath: Remove parse_function_helperArseny Kapoulkine
It was only used in three places and didn't really make the code more readable.
2017-01-29XPath: alloc_string no longer returns NULLArseny Kapoulkine
NULL return value will be reserved for the OOM error indicator.
2017-01-26Update copyright year to 2017Arseny Kapoulkine
2017-01-17Added target_include_directories() to properly export include directories (#130)Daniel Knibbe
Fixes #126
2016-12-01Work around cray++ compiler issueArseny Kapoulkine
It's still not clear as to what exactly makes it emit this error when compiling string_to_integer: CC-3059 crayc++: INTERNAL __C_FILE_SCOPE_DATA__, File = <pugixml>/src/pugixml.cpp, Line = 4524, Column = 4 Expected no overflow in routine. But a viable workaround for now is to exploit the knowledge that it uses two-complement arithmetics and invert the sign manually. Fixes #125.
2016-11-28scripts: Make archive build reproducibleArseny Kapoulkine
We used to use the current timestamp when building the archive; switch to using the timestamp of the tag with the version we're packaging. This requires some monkey patching since tarfile module is always using current timestamp when writing gzip header... Also exclude archive.py from archive and simplify release file list in Makefile.
2016-11-27scripts: Move archive.py from testsArseny Kapoulkine
2016-11-27Fix archive script to set timestamps properly for .tar.gzv1.8.1Arseny Kapoulkine
By default they are set to Jan 1 1970 which breaks homebrew. Fixes #124.
2016-11-24docs: Regenerate HTML documentationv1.8latestArseny Kapoulkine
2016-11-19tests: Fix unused variable warning in some compilersArseny Kapoulkine
The variable is being assigned to but never read when exceptions are disabled.
2016-11-18Silence 'cast increases required alignment of target type' warningsArseny Kapoulkine
These warnings are emitted on some GCC versions when targeting ARM; the alignment is guaranteed to be correct due to how page offsets are set up but the compiler doesn't know.
2016-11-17Rename set_value_convert to set_value_boolArseny Kapoulkine
It's too dangerous to overload here - easy to accidentally mix floating point path with boolean one.
2016-11-17Fix 'comparison of unsigned expression < 0 is always false' warningsArseny Kapoulkine
Unfortunately, some compilers don't suppress these kinds of warnings in template instantiations; solve this by moving the responsibility for computing negative bool to the caller. Also since we're doing that we don't really need to convert to unsigned in the implementation - might as well have the caller do it, which removes some type dispatch logic and slightly reduces binary size.
2016-11-13scripts: Change VS2013 projects to use /Z7Arseny Kapoulkine
Put debugging information into the object file so that it can be shipped with NuGet binaries. Based on the linker settings for the executable debug info will either be put into the final .PDB or stripped out. Fixes #110.
2016-11-13Set 1.8 release date to (tentatively) Nov 24.Arseny Kapoulkine
2016-11-13Change status_end_element_mismatch to point to closing tag nameArseny Kapoulkine
Previously the error offset pointed to the first mismatching character, which can be confusing especially if the start tag name is a prefix of the end tag name. Instead, move the offset to the first character of the name - that way it should be more obvious that the problem is that the entire name mismatches. Fixes #112.
2016-11-13Rewrite archive script into PythonArseny Kapoulkine
Perl version needed Archive::Zip that for some reason is not installed on WSL by default. Use this as an opportunity to remove the last Perl script.
2016-11-09tests: Fix MSVC warningsArseny Kapoulkine
2016-11-09tests: Add a generalized write-roundtrip testArseny Kapoulkine
This test tests two important invariants: - Every combination of write flags has to result in a valid document - Parsing that document and saving the result has to result in identical output We don't test all flags since parse_no_escapes can intentionally result in malformed documents and other flags aren't relevant for node output. Also note that we test both no-whitespace and whitespace version to make sure we don't have unnecessary whitespace added during formatting.
2016-11-09docs: Add documentation for format_no_empty_element_tagsArseny Kapoulkine
Also add it to the changelog for 1.8
2016-11-09tests: Add a test for format_no_empty_element_tagsArseny Kapoulkine
2016-11-09Add format_no_empty_element_tags flagArseny Kapoulkine
Setting this flag outputs start and end tag for every element, including empty elements. Fixes #118.
2016-11-09Update version to 1.8 everywhereArseny Kapoulkine
2016-11-09docs: Add changelog draft for 1.8Arseny Kapoulkine
2016-11-08XPath: Fix source indentationArseny Kapoulkine
Split some lines into two and add braces in some places to make the code more readable.
2016-11-07Move compact hash table pointer setup to xml_documentArseny Kapoulkine
This keeps all code that creates document/allocator/page structures together.
2016-11-07Remove xml_allocator copying during parsingArseny Kapoulkine
The separate copy of allocator state in parser was meant to increase parsing performance by reducing aliasing/indirection, but benchmarks against the current source don't indicate that this is worthwhile. Removing this simplifies the code slightly and makes it possible to move compact hash table to the allocator.
2016-11-07Rename xml_document::create/destroy for consistencyArseny Kapoulkine
2016-11-06tests: Don't use ranged for loop in move testsArseny Kapoulkine
Some compilers support move semantics but don't support ranged for.
2016-11-06Reduce MSVC version cutoff for move semantics supportArseny Kapoulkine
MSVC 2010 supported move semantics (partially - but should be good enough for our use case).
2016-11-06Refactor move semantics support detectionArseny Kapoulkine
Do it in one place and set PUGIXML_HAS_MOVE if it's available.
2016-11-06Add VS2013 check for C++11 availability (#121)iFarbod
VS 2013 supports C++11, but __cplusplus macro isn't updated, and it is 199711 so the old check always fails, even though the compiler supports c++11.
2016-10-17Merge pull request #119 from pavelkryukov/masterArseny Kapoulkine
Add C++11 'override' specifier
2016-10-18Fix a comment before PUGIXML_OVERRIDE macroPavel Kryukov